tests/unit/web/routes/auth.test.ts (2)

270-278: Consider asserting the error message for consistency.

Unlike other tests in this file, this test only checks resStatus but not the response.error message. Adding an assertion for the error message would make it consistent with the other validation tests.

Suggested improvement

     await routes.register(mockReq as IncomingMessage, mockRes as ServerResponse);

     expect(resStatus).toBe(400);
+    const response = JSON.parse(resBody);
+    expect(response.error).toBe('All fields are required');
   });

---

854-868: Consider consolidating this test into the existing logout describe block.

There's already a describe('logout', ...) block starting at line 464 that contains similar tests, including one for logout errors (lines 493-505). Moving this test case into that block would improve organization and avoid the somewhat awkward "logout - additional cases" naming.

Suggested consolidation

Move this test into the existing logout describe block (after line 505):

     it('should handle logout errors', async () => {
       vi.mocked(authService.logout).mockRejectedValue(new Error('Logout failed'));
       // ... existing test
     });
+
+    it('should handle unknown logout errors', async () => {
+      vi.mocked(authService.logout).mockRejectedValue('Unknown error');
+
+      mockReq = createMockRequest({
+        refreshToken: 'refresh-token',
+      });
+
+      await routes.logout(mockReq as IncomingMessage, mockRes as ServerResponse);
+
+      expect(resStatus).toBe(500);
+      const response = JSON.parse(resBody);
+      expect(response.error).toBe('Logout failed');
+    });
   });

Then remove the separate describe('logout - additional cases', ...) block.

src/mcp/tools/task-tools.ts (1)

509-560: Consider using Zod schemas for input validation consistency.

The existing task tools (e.g., task_create, task_assign) use Zod schemas for input validation, but the new consensus tools use raw type assertions (params.agentType as string). This creates inconsistent error handling—Zod provides structured validation errors, while type assertions may produce unclear runtime errors.

♻️ Example: Add Zod schema for consensus_check

// Add near other schemas at the top of the file
const ConsensusCheckInputSchema = z.object({
  agentType: z.string().min(1).describe('Agent type for this task'),
  input: z.string().optional().describe('Task input/description'),
  parentTaskId: z.string().uuid().optional().describe('Parent task ID'),
  riskLevel: z.enum(['low', 'medium', 'high']).optional().describe('Risk level override'),
});

// Then in the handler:
handler: async (params: Record<string, unknown>) => {
  if (!consensusService) {
    return { success: false, error: 'Consensus service not available' };
  }

  try {
    const input = ConsensusCheckInputSchema.parse(params);
    // ... rest of handler using input.agentType, input.input, etc.
  }
}

src/tasks/consensus-service.ts (1)

455-460: Consider making the expiration check interval configurable.

The hardcoded 60-second interval works but could be made configurable for different deployment scenarios (e.g., shorter intervals for time-sensitive environments).